Getting Started update #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st to account for the changes and have the files needed
… the examples code. Can be run from start to end from a user + works with doctest
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 109 109
Lines 5698 5700 +2
Branches 323 323
=======================================
+ Hits 5412 5414 +2
Misses 285 285
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roosre
reviewed
Jan 29, 2025
Co-authored-by: René Roos <[email protected]>
greschd
reviewed
Jan 29, 2025
greschd
reviewed
Jan 29, 2025
|
Looks good to me overall, I just added some comments regarding variable names for the example files. |
…pyacp into docs/getting_started_file
greschd
approved these changes
Jan 29, 2025
Co-authored-by: Dominik Gresch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Getting Started section of the documentation such that it can be done from a user (solves #771), Code to download the examples file has also been added.